lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAJq09z4G40ttsTHXtOywjyusNLSjt_BQ9D78PhwSodJr=4p6OA@mail.gmail.com> Date: Sat, 29 Jan 2022 13:02:32 -0300 From: Luiz Angelo Daros de Luca <luizluca@...il.com> To: Rob Herring <robh@...nel.org>, Alvin Šipraga <ALSI@...g-olufsen.dk>, Linus Walleij <linus.walleij@...aro.org> Cc: devicetree@...r.kernel.org, Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>, Arınç ÜNAL <arinc.unal@...nc9.com>, Florian Fainelli <f.fainelli@...il.com>, Stephen Rothwell <sfr@...b.auug.org.au>, Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>, Vladimir Oltean <olteanv@...il.com>, "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] dt-bindings: net: dsa: realtek-smi: convert to YAML schema Thanks Rob, now that the code side is merged, I'm back to docs. > > + interrupt-controller: > > + description: see interrupt-controller/interrupts.txt > > Don't need generic descriptions. Just 'true' here is fine. Do you really mean quoted true, like in "description: 'true' "? Without quotes it will fail > > > + > > + interrupts: > > + description: TODO > > You have to define how many interrupts and what they are. I didn't write the interruption code and Linus and Alvin might help here. The switch has a single interrupt pin that signals an interruption happened. The code reads a register to multiplex to these interruptions: INT_TYPE_LINK_STATUS = 0, INT_TYPE_METER_EXCEED, INT_TYPE_LEARN_LIMIT, INT_TYPE_LINK_SPEED, INT_TYPE_CONGEST, INT_TYPE_GREEN_FEATURE, INT_TYPE_LOOP_DETECT, INT_TYPE_8051, INT_TYPE_CABLE_DIAG, INT_TYPE_ACL, INT_TYPE_RESERVED, /* Unused */ INT_TYPE_SLIENT, And most of them, but not all, multiplex again to each port. However, the linux driver today does not care about any of these interruptions but INT_TYPE_LINK_STATUS. So it simply multiplex only this the interruption to each port, in a n-cell map (n being number of ports). I don't know what to describe here as device-tree should be something independent of a particular OS or driver. Anyway, I doubt someone might want to plug one of these interruptions outside the switch driver. Could it be simple as this: interrupts: minItems: 3 maxItems: 10 description: interrupt mapping one per switch port Once realtek-smi.yaml settles, I'll also send the realtek-mdio.yaml. Regards, Luiz
Powered by blists - more mailing lists