lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 29 Jan 2022 22:35:39 +0300
From:   Arınç ÜNAL <>
To:     Luiz Angelo Daros de Luca <>,
        Rob Herring <>,
        Alvin Šipraga <>,
        Linus Walleij <>
Cc:, Arnd Bergmann <>,
        Olof Johansson <>,
        Florian Fainelli <>,
        Stephen Rothwell <>,
        Andrew Lunn <>,
        Vivien Didelot <>,
        Vladimir Oltean <>,
        "David S . Miller" <>,
        Jakub Kicinski <>,
        "open list:NETWORKING DRIVERS" <>,
        open list <>
Subject: Re: [PATCH] dt-bindings: net: dsa: realtek-smi: convert to YAML

On 29/01/2022 19:02, Luiz Angelo Daros de Luca wrote:
> Thanks Rob, now that the code side is merged, I'm back to docs.
>>> +      interrupt-controller:
>>> +        description: see interrupt-controller/interrupts.txt
>> Don't need generic descriptions. Just 'true' here is fine.
> Do you really mean quoted true, like in "description: 'true' "?
> Without quotes it will fail
>>> +
>>> +      interrupts:
>>> +        description: TODO
>> You have to define how many interrupts and what they are.
> I didn't write the interruption code and Linus and Alvin might help here.
> The switch has a single interrupt pin that signals an interruption happened.
> The code reads a register to multiplex to these interruptions:
> INT_TYPE_8051,
> INT_TYPE_RESERVED, /* Unused */
> And most of them, but not all, multiplex again to each port.
> However, the linux driver today does not care about any of these
> interruptions but INT_TYPE_LINK_STATUS. So it simply multiplex only
> this the interruption to each port, in a n-cell map (n being number of
> ports).
> I don't know what to describe here as device-tree should be something
> independent of a particular OS or driver.
> Anyway, I doubt someone might want to plug one of these interruptions
> outside the switch driver. Could it be simple as this:
>        interrupts:
>         minItems: 3
>         maxItems: 10
>         description:
>           interrupt mapping one per switch port
> Once realtek-smi.yaml settles, I'll also send the realtek-mdio.yaml.

Why not turn realtek-smi.yaml into realtek.yaml which would also contain 
information for the mdio interface? The things different with using MDIO 
are that we don't use the [mdc,mdio,reset]-gpios properties and don't 
handle the PHYs to the DSA ports. Couldn't you present these differences 
on a single YAML file?


Powered by blists - more mailing lists