netdev - Re: [PATCH iproute2 v3 1/2] tc: u32: add support for json output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20320139-9b94-8c64-21e9-2fb2f2b34943@mojatatu.com>
Date:   Mon, 31 Jan 2022 14:37:56 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     David Ahern <dsahern@...il.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Andrea Claudi <aclaudi@...hat.com>
Cc:     netdev@...r.kernel.org, Wen Liang <wenliang@...hat.com>,
        David Ahern <dsahern@...nel.org>,
        Victor Nogueira <victor@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Davide Caratti <dcaratti@...hat.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Vlad Buslov <vladbu@...dia.com>
Subject: Re: [PATCH iproute2 v3 1/2] tc: u32: add support for json output

On 2022-01-31 10:50, David Ahern wrote:
> On 1/31/22 5:54 AM, Jamal Hadi Salim wrote:
>>>> Do you need a patch for that in some documentation?
>>>>
>>>
>>> How about adding some comments to README.devel?
>>
>>
>> Sure - but it wont be sufficient IMO.
>> Best course of action is for the maintainers to remind people to run
>> tests.
> 
> Above, you said the tests were meant for bots.
> 

The invocation that tdc.sh makes is targeted for the bots.
It only tests actions and qdiscs.
If you run  ./tdc.py -h you'll see more options.

>>
>> BTW: We found out that Stephen's patches still break the latest -next.
>>
> 
> ugh. I committed them after running tdc.sh and not seeing a change in
> output. We'll need fixup patches then.
> 
> Clearly some work is needed on getting the test suite usable by a wider
> audience. I am new to running those tests as well and probably had some
> pilot errors running them.
> 

One of the issues is sometimes some of the tests take a while to
complete, so some tweaking of the timer may be needed depending on your
setup etc. Probably that is what you may be running into.

> I do wait for ACKs from tc folks, but can't wait forever. Right now
> there is the 'skip_hw' and 'skip_sw' patch that Victor sent a Tested-by.
> When I apply that v2 patch, I see errors in the tdc.sh output so my
> mileage varies from Victor's. There is also the v5 of this set which I
> have no applied yet; it could use some acks and tdc testing as well.

ok. Punting to Victor for testing the v5 - was it posted on the list?
I will Ack Bowen's patch.

cheers,
jamal