netdev - Re: [PATCH iproute2-next v2] tc: add skip_hw and skip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b24054ae-7267-b5ca-363b-9c219fb05a98@mojatatu.com>
Date:   Mon, 31 Jan 2022 14:40:43 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Victor Nogueira <victor@...atatu.com>,
        Baowen Zheng <baowen.zheng@...igine.com>
Cc:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org,
        oss-drivers@...igine.com, Simon Horman <simon.horman@...igine.com>
Subject: Re: [PATCH iproute2-next v2] tc: add skip_hw and skip_sw to control
 action offload

On 2022-01-26 08:41, Victor Nogueira wrote:
> On Wed, Jan 26, 2022 at 3:55 AM Baowen Zheng <baowen.zheng@...igine.com> wrote:
>>
>> Add skip_hw and skip_sw flags for user to control whether
>> offload action to hardware.
>>
>> Also we add hw_count to show how many hardwares accept to offload
>> the action.
>>
>> Change man page to describe the usage of skip_sw and skip_hw flag.
>>
>> An example to add and query action as below.
>>
>> $ tc actions add action police rate 1mbit burst 100k index 100 skip_sw
>>
>> $ tc -s -d actions list action police
>> total acts 1
>>      action order 0:  police 0x64 rate 1Mbit burst 100Kb mtu 2Kb action reclassify overhead 0b linklayer ethernet
>>      ref 1 bind 0  installed 2 sec used 2 sec
>>      Action statistics:
>>      Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
>>      backlog 0b 0p requeues 0
>>      skip_sw in_hw in_hw_count 1
>>      used_hw_stats delayed
>>
>> Signed-off-by: baowen zheng <baowen.zheng@...igine.com>
>> Signed-off-by: Simon Horman <simon.horman@...igine.com>
> 
> I applied this version, tested it and can confirm the breakage in tdc is gone.
> Tested-by: Victor Nogueira <victor@...atatu.com>

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal