netdev - Re: [PATCH ipsec-next] xfrm: delete duplicated functions that calls same xfrm_api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220201070701.GU1223722@gauss3.secunet.de>
Date:   Tue, 1 Feb 2022 08:07:01 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        Leon Romanovsky <leonro@...dia.com>, <netdev@...r.kernel.org>,
        Shannon Nelson <shannon.nelson@...cle.com>
Subject: Re: [PATCH ipsec-next] xfrm: delete duplicated functions that calls
 same xfrm_api_check()

On Thu, Jan 27, 2022 at 11:08:40AM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@...dia.com>
> 
> The xfrm_dev_register() and xfrm_dev_feat_change() have same
> implementation of one call to xfrm_api_check(). Instead of doing such
> indirection, call to xfrm_api_check() directly and delete duplicated
> functions.
> 
> Fixes: 92a2320697f7 ("xfrm: check for xdo_dev_ops add and delete")

There was nothing broken here, just a suboptimal implementation.
So please remove the Fixes tag, otherwise it gets backported
without a need.

Thanks!

> Signed-off-by: Leon Romanovsky <leonro@...dia.com>
> ---
>  net/xfrm/xfrm_device.c | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/net/xfrm/xfrm_device.c b/net/xfrm/xfrm_device.c
> index 3fa066419d37..36d6c1835844 100644
> --- a/net/xfrm/xfrm_device.c
> +++ b/net/xfrm/xfrm_device.c
> @@ -380,16 +380,6 @@ static int xfrm_api_check(struct net_device *dev)
>  	return NOTIFY_DONE;
>  }
>  
> -static int xfrm_dev_register(struct net_device *dev)
> -{
> -	return xfrm_api_check(dev);
> -}
> -
> -static int xfrm_dev_feat_change(struct net_device *dev)
> -{
> -	return xfrm_api_check(dev);
> -}
> -
>  static int xfrm_dev_down(struct net_device *dev)
>  {
>  	if (dev->features & NETIF_F_HW_ESP)
> @@ -404,10 +394,10 @@ static int xfrm_dev_event(struct notifier_block *this, unsigned long event, void
>  
>  	switch (event) {
>  	case NETDEV_REGISTER:
> -		return xfrm_dev_register(dev);
> +		return xfrm_api_check(dev);
>  
>  	case NETDEV_FEAT_CHANGE:
> -		return xfrm_dev_feat_change(dev);
> +		return xfrm_api_check(dev);
>  
>  	case NETDEV_DOWN:
>  	case NETDEV_UNREGISTER:
> -- 
> 2.34.1