netdev - Re: [PATCH v2 2/2] sh_eth: sh_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2de76f03-aea3-cfe4-72b3-a8b93c8b6dd1@gmail.com>
Date:   Wed, 2 Feb 2022 17:57:05 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Sergey Shtylyov <s.shtylyov@....ru>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] sh_eth: sh_eth_close() always returns 0

On 01.02.2022 11:58, Geert Uytterhoeven wrote:

[...]
>> sh_eth_close() always returns 0, hence the check in sh_eth_wol_restore()
>> is pointless (however we cannot change the prototype of sh_eth_close() as
>> it implements the driver's ndo_stop() method).
>>
>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>> analysis tool.
>>
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@....ru>
> 
> Thanks for your patch!
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> 
> Note that there's a second call in sh_eth_suspend().

   Made no sense to change it. :-)

> Gr{oetje,eeting}s,
> 
>                          Geert

MBR, Sergey