lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 04 Feb 2022 04:18:24 -0800 From: Joe Perches <joe@...ches.com> To: "Russell King (Oracle)" <linux@...linux.org.uk>, nick.hawkins@....com Cc: verdun@....com, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, Rob Herring <robh+dt@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, Corey Minyard <minyard@....org>, Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>, Miquel Raynal <miquel.raynal@...tlin.com>, Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Thierry Reding <thierry.reding@...il.com>, Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, Lee Jones <lee.jones@...aro.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Mark Brown <broonie@...nel.org>, "Rafael J. Wysocki" <rafael@...nel.org>, Daniel Lezcano <daniel.lezcano@...aro.org>, Amit Kucheria <amitk@...nel.org>, Zhang Rui <rui.zhang@...el.com>, Thomas Gleixner <tglx@...utronix.de>, Wim Van Sebroeck <wim@...ux-watchdog.org>, Guenter Roeck <linux@...ck-us.net>, Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>, soc@...nel.org, Shawn Guo <shawnguo@...nel.org>, Stanislav Jakubek <stano.jakubek@...il.com>, Sam Ravnborg <sam@...nborg.org>, Hao Fang <fanghao11@...wei.com>, Mark Rutland <mark.rutland@....com>, Marc Zyngier <maz@...nel.org>, Ard Biesheuvel <ardb@...nel.org>, Anshuman Khandual <anshuman.khandual@....com>, Wang Kefeng <wangkefeng.wang@...wei.com>, Lukas Bulwahn <lukas.bulwahn@...il.com>, Masahiro Yamada <masahiroy@...nel.org>, dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, linux-i2c@...r.kernel.org, openipmi-developer@...ts.sourceforge.net, linux-mtd@...ts.infradead.org, netdev@...r.kernel.org, linux-pwm@...r.kernel.org, linux-serial@...r.kernel.org, linux-spi@...r.kernel.org, linux-pm@...r.kernel.org, linux-usb@...r.kernel.org, linux-watchdog@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH] HPE BMC GXP SUPPORT On Fri, 2022-02-04 at 12:05 +0000, Russell King (Oracle) wrote: > On Wed, Feb 02, 2022 at 10:52:50AM -0600, nick.hawkins@....com wrote: [] > > diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile [] > > +static irqreturn_t gxp_time_interrupt(int irq, void *dev_id) > > +{ > > + struct gxp_timer *timer = dev_id; > > + void (*event_handler)(struct clock_event_device *timer); > > + > > + > > One too many blank lines. > > > + if (readb_relaxed(timer->control) & MASK_TCS_TC) { > > + writeb_relaxed(MASK_TCS_TC, timer->control); > > + > > + event_handler = READ_ONCE(timer->evt.event_handler); > > + if (event_handler) > > + event_handler(&timer->evt); > > + return IRQ_HANDLED; > > + } else { > > + return IRQ_NONE; > > + } > > +} It's also less indented code and perhaps clearer to reverse the test if (!readb_relaxed(timer->control) & MASK_TCS_TC) return IRQ_NONE; writeb_relaxed(MASK_TCS_TC, timer->control); event_handler = READ_ONCE(timer->evt.event_handler); if (event_handler) event_handler(&timer->evt); return IRQ_HANDLED;
Powered by blists - more mailing lists