netdev - Re: [PATCH net-next 0/2] gro: a couple of minor optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220204121606.81211-1-alexandr.lobakin@intel.com>
Date:   Fri,  4 Feb 2022 13:16:06 +0100
From:   Alexander Lobakin <alexandr.lobakin@...el.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     Alexander Lobakin <alexandr.lobakin@...el.com>,
        netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Alexander H Duyck <alexander.duyck@...il.com>
Subject: Re: [PATCH net-next 0/2] gro: a couple of minor optimization

From: Paolo Abeni <pabeni@...hat.com>
Date: Fri,  4 Feb 2022 12:28:35 +0100

> This series collects a couple of small optimizations for the GRO engine,
> reducing slightly the number of cycles for dev_gro_receive().
> The delta is within noise range in tput tests, but with big TCP coming
> every cycle saved from the GRO engine will count - I hope ;)
> 
> v1 -> v2:
>  - a few cleanup suggested from Alexander(s)
>  - moved away the more controversial 3rd patch
> 
> Paolo Abeni (2):
>   net: gro: avoid re-computing truesize twice on recycle
>   net: gro: minor optimization for dev_gro_receive()

Looks nice to me now, thanks!
For the series:

Reviewed-by: Alexander Lobakin <alexandr.lobakin@...el.com>

> 
>  include/net/gro.h | 52 +++++++++++++++++++++++++----------------------
>  net/core/gro.c    | 16 ++++-----------
>  2 files changed, 32 insertions(+), 36 deletions(-)
> 
> -- 
> 2.34.1

Al