netdev - Re: [PATCH net-next 0/2] gro: a couple of minor optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKgT0UeNKjFYZkUfXCX8W8DTxJH7bXxCfERH6e0w6DZ2+N5v1g@mail.gmail.com>
Date:   Fri, 4 Feb 2022 07:55:14 -0800
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     Netdev <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Alexander Lobakin <alexandr.lobakin@...el.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next 0/2] gro: a couple of minor optimization

On Fri, Feb 4, 2022 at 3:29 AM Paolo Abeni <pabeni@...hat.com> wrote:
>
> This series collects a couple of small optimizations for the GRO engine,
> reducing slightly the number of cycles for dev_gro_receive().
> The delta is within noise range in tput tests, but with big TCP coming
> every cycle saved from the GRO engine will count - I hope ;)
>
> v1 -> v2:
>  - a few cleanup suggested from Alexander(s)
>  - moved away the more controversial 3rd patch
>
> Paolo Abeni (2):
>   net: gro: avoid re-computing truesize twice on recycle
>   net: gro: minor optimization for dev_gro_receive()
>
>  include/net/gro.h | 52 +++++++++++++++++++++++++----------------------
>  net/core/gro.c    | 16 ++++-----------
>  2 files changed, 32 insertions(+), 36 deletions(-)

This addresses the concern I had.

Reviewed-by: Alexander Duyck <alexanderduyck@...com>