netdev - Re: [PATCH net-next v6 05/13] net: dsa: realtek: convert subdrivers into modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220204075319.18e43379@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 4 Feb 2022 07:53:19 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Arınç ÜNAL <arinc.unal@...nc9.com>
Cc:     Luiz Angelo Daros de Luca <luizluca@...il.com>,
        netdev@...r.kernel.org, linus.walleij@...aro.org, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com, olteanv@...il.com,
        alsi@...g-olufsen.dk, frank-w@...lic-files.de, davem@...emloft.net
Subject: Re: [PATCH net-next v6 05/13] net: dsa: realtek: convert subdrivers
 into modules

On Fri, 4 Feb 2022 10:57:22 +0300 Arınç ÜNAL wrote:
> > Why did all these new config options grow a 'default y'? Our usual
> > policy is to default drivers to disabled.  
> 
> NET_DSA_REALTEK_SMI and NET_DSA_REALTEK_MDIO also have got "default y".
> 
> Respectively:
> 319a70a5fea9 ("net: dsa: realtek-smi: move to subdirectory")
> aac94001067d ("net: dsa: realtek: add new mdio interface for drivers")
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/diff/drivers/net/dsa/realtek/Kconfig?id=319a70a5fea9590e9431dd57f56191996c4787f4
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/diff/drivers/net/dsa/realtek/Kconfig?id=aac94001067da183455d6d37959892744fa01d9d

Indeed, so far we had been doing the opposite what this driver has done
- set the "vendor selection" i.e. NET_DSA_REALTEK default to y since it
doesn't build any code, and the actual code default to n. We are
considering defaulting everything to n now, but it's WIP.

Let me send a patch dropping the default y, please object if there was
a strong reason to do it this way!