netdev - Re: [PATCH net-next v6 05/13] net: dsa: realtek: convert subdrivers into modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <71769232-1502-bd59-0d72-129dbe72efb6@arinc9.com>
Date:   Fri, 4 Feb 2022 10:57:22 +0300
From:   Arınç ÜNAL <arinc.unal@...nc9.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Luiz Angelo Daros de Luca <luizluca@...il.com>
Cc:     netdev@...r.kernel.org, linus.walleij@...aro.org, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com, olteanv@...il.com,
        alsi@...g-olufsen.dk, frank-w@...lic-files.de, davem@...emloft.net
Subject: Re: [PATCH net-next v6 05/13] net: dsa: realtek: convert subdrivers
 into modules

On 04/02/2022 04:58, Jakub Kicinski wrote:
> On Fri, 28 Jan 2022 03:05:01 -0300 Luiz Angelo Daros de Luca wrote:
>> diff --git a/drivers/net/dsa/realtek/Kconfig b/drivers/net/dsa/realtek/Kconfig
>> index 1c62212fb0ec..cd1aa95b7bf0 100644
>> --- a/drivers/net/dsa/realtek/Kconfig
>> +++ b/drivers/net/dsa/realtek/Kconfig
>> @@ -2,8 +2,6 @@
>>   menuconfig NET_DSA_REALTEK
>>   	tristate "Realtek Ethernet switch family support"
>>   	depends on NET_DSA
>> -	select NET_DSA_TAG_RTL4_A
>> -	select NET_DSA_TAG_RTL8_4
>>   	select FIXED_PHY
>>   	select IRQ_DOMAIN
>>   	select REALTEK_PHY
>> @@ -18,3 +16,21 @@ config NET_DSA_REALTEK_SMI
>>   	help
>>   	  Select to enable support for registering switches connected
>>   	  through SMI.
>> +
>> +config NET_DSA_REALTEK_RTL8365MB
>> +	tristate "Realtek RTL8365MB switch subdriver"
>> +	default y
>> +	depends on NET_DSA_REALTEK
>> +	depends on NET_DSA_REALTEK_SMI
>> +	select NET_DSA_TAG_RTL8_4
>> +	help
>> +	  Select to enable support for Realtek RTL8365MB
>> +
>> +config NET_DSA_REALTEK_RTL8366RB
>> +	tristate "Realtek RTL8366RB switch subdriver"
>> +	default y
>> +	depends on NET_DSA_REALTEK
>> +	depends on NET_DSA_REALTEK_SMI
>> +	select NET_DSA_TAG_RTL4_A
>> +	help
>> +	  Select to enable support for Realtek RTL8366RB
> 
> Why did all these new config options grow a 'default y'? Our usual
> policy is to default drivers to disabled.

NET_DSA_REALTEK_SMI and NET_DSA_REALTEK_MDIO also have got "default y".

Respectively:
319a70a5fea9 ("net: dsa: realtek-smi: move to subdirectory")
aac94001067d ("net: dsa: realtek: add new mdio interface for drivers")

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/diff/drivers/net/dsa/realtek/Kconfig?id=319a70a5fea9590e9431dd57f56191996c4787f4

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/diff/drivers/net/dsa/realtek/Kconfig?id=aac94001067da183455d6d37959892744fa01d9d