netdev - Re: [PATCH net-next 1/2] net: gro: avoid re-computing truesize twice on recycle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iK_HbZVCpjD2=yivkYXf5n_BoSSiaQqKAq4uxETwrtRjA@mail.gmail.com>
Date:   Fri, 4 Feb 2022 08:34:35 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Alexander Lobakin <alexandr.lobakin@...el.com>,
        Alexander H Duyck <alexander.duyck@...il.com>
Subject: Re: [PATCH net-next 1/2] net: gro: avoid re-computing truesize twice
 on recycle

On Fri, Feb 4, 2022 at 3:29 AM Paolo Abeni <pabeni@...hat.com> wrote:
>
> After commit 5e10da5385d2 ("skbuff: allow 'slow_gro' for skb
> carring sock reference") and commit af352460b465 ("net: fix GRO
> skb truesize update") the truesize of the skb with stolen head is
> properly updated by the GRO engine, we don't need anymore resetting
> it at recycle time.
>
> v1 -> v2:
>  - clarify the commit message (Alexander)
>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>