netdev - Re: [PATCH net] igc: Clear old XDP info when changing ring settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Feb 2022 17:04:58 +0000
From:   "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
To:     "Gomes, Vinicius" <vinicius.gomes@...el.com>,
        "kurt@...utronix.de" <kurt@...utronix.de>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "andre.guedes@...el.com" <andre.guedes@...el.com>,
        "Joseph, Jithu" <jithu.joseph@...el.com>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        "hawk@...nel.org" <hawk@...nel.org>,
        "ast@...nel.org" <ast@...nel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "vedang.patel@...el.com" <vedang.patel@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] igc: Clear old XDP info when changing ring settings

Hi Kurt,

On Fri, 2022-02-04 at 09:02 +0100, Kurt Kanzenbach wrote:
> When changing ring sizes the driver triggers kernel warnings in XDP
> code.
> 
> For instance, running 'ethtool -G $interface tx 1024 rx 1024' yields:
> 
> > [  754.838136] Missing unregister, handled but fix driver
> > [  754.838143] WARNING: CPU: 4 PID: 704 at net/core/xdp.c:170
> > xdp_rxq_info_reg+0x7d/0xe0
> 
> The newly allocated ring is copied by memcpy() and still contains the
> old XDP
> information. Therefore, it has to be cleared before allocating new
> resources
> by igc_setup_rx_resources().
> 
> Igb does it the same way. Keep the code in sync.

Thanks for the patch, but we have a patch[1] to resolve this issue in a
more preferred method. igb is actually changing as well to this new
solution [2].

Thanks,
Tony

[1] https://patchwork.ozlabs.org/patch/1581816/
[2] https://patchwork.ozlabs.org/patch/1581815/

> Fixes: 4609ffb9f615 ("igc: Refactor XDP rxq info registration")
> Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>