netdev - Re: [PATCH net-next] net: dsa: qca8k: check correct variable in qca8k_phy_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23b8c673-9fd7-0ddc-3eee-935e6cbd2dc2@gmail.com>
Date:   Fri, 4 Feb 2022 09:06:25 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Andrew Lunn <andrew@...n.ch>,
        Ansuel Smith <ansuelsmth@...il.com>
Cc:     Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: qca8k: check correct variable in
 qca8k_phy_eth_command()



On 2/4/2022 2:03 AM, Dan Carpenter wrote:
> This is a copy and paste bug.  It was supposed to check "clear_skb"
> instead of "write_skb".
> 
> Fixes: 2cd548566384 ("net: dsa: qca8k: add support for phy read/write with mgmt Ethernet")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian