netdev - Re: [PATCH devicetree v3] dt-bindings: phy: Add `tx-p2p-microvolt` property binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Feb 2022 19:18:27 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Marek Behún <kabel@...nel.org>,
        devicetree@...r.kernel.org, Vladimir Oltean <olteanv@...il.com>,
        Holger Brunck <holger.brunck@...achienergy.com>,
        Andrew Lunn <andrew@...n.ch>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Russell King <rmk+kernel@...linux.org.uk>,
        linux-phy@...ts.infradead.org, Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...com>
Subject: Re: [PATCH devicetree v3] dt-bindings: phy: Add `tx-p2p-microvolt`
 property binding



On 2/4/2022 6:18 PM, Rob Herring wrote:
> On Fri, Jan 21, 2022 at 11:18:09AM -0800, Florian Fainelli wrote:
>> On 1/19/22 5:11 AM, Marek Behún wrote:
>>> Common PHYs and network PCSes often have the possibility to specify
>>> peak-to-peak voltage on the differential pair - the default voltage
>>> sometimes needs to be changed for a particular board.
>>>
>>> Add properties `tx-p2p-microvolt` and `tx-p2p-microvolt-names` for this
>>> purpose. The second property is needed to specify the mode for the
>>> corresponding voltage in the `tx-p2p-microvolt` property, if the voltage
>>> is to be used only for speficic mode. More voltage-mode pairs can be
>>> specified.
>>>
>>> Example usage with only one voltage (it will be used for all supported
>>> PHY modes, the `tx-p2p-microvolt-names` property is not needed in this
>>> case):
>>>
>>>    tx-p2p-microvolt = <915000>;
>>>
>>> Example usage with voltages for multiple modes:
>>>
>>>    tx-p2p-microvolt = <915000>, <1100000>, <1200000>;
>>>    tx-p2p-microvolt-names = "2500base-x", "usb", "pcie";
>>>
>>> Add these properties into a separate file phy/transmit-amplitude.yaml,
>>> which should be referenced by any binding that uses it.
>>
>> p2p commonly means peer to peer which incidentally could be confusing,
>> can you spell out the property entire:
>>
>> tx-peaktopeak-microvolt or:
>>
>> tx-pk2pk-microvolt for a more compact name maybe?
> 
> Peer to peer makes little sense in terms of a voltage. I think this is
> fine as-is.

Understood, my point was that peer is a word that is commonly used in an 
environment where you are talking about networking equipment at large. 
Anyway, feel free to ignore it.
-- 
Florian