netdev - Re: [PATCH] net: phy: marvell: Fix RGMII Tx/Rx delays setting in 88e1121-compatible PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 5 Feb 2022 17:25:44 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Pavel.Parkhomenko@...kalelectronics.ru
Cc:     Alexey.Malahov@...kalelectronics.ru,
        Sergey.Semin@...kalelectronics.ru, linux-kernel@...r.kernel.org,
        michael@...pelberg.de, afleming@...il.com, f.fainelli@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: phy: marvell: Fix RGMII Tx/Rx delays setting in
 88e1121-compatible PHYs

On Sat, Feb 05, 2022 at 03:22:44PM +0000, Pavel.Parkhomenko@...kalelectronics.ru wrote:
> On Fri, 04/02/2022 at 14:10 +0100, Andrew Lunn wrote:
> > Hi Pavel
> > 
> > There appears to be another path which has the same issue.
> > 
> > m88e1118_config_aneg() calls marvell_set_polarity(), which also needs
> > a reset afterwards.
> > 
> > Could you fix this case as well?
> > 
> > Thanks
> >         Andrew
> 
> m88e1118_config_aneg() was added back in 2008 and has unconditional
> genphy_soft_reset() at the very beginning. I haven't got 88E1118R or
> 88E11149R by the hand and the full documentation is also not available.
> I believe that in this case it would be safe to still issue reset
> unconditionally, but do it at the very end of m88e1118_config_aneg().
> Anyways, I'd like to post it as a separate patch as I cannot test the fix
> properly, unlike previous patch regarding 88E1510.

All the datasheets i have follow the same scheme, you need to perform
a reset at some point to get changes to actually apply. So i doubt
1118r is any different.

Posting a separate patch is fine.

Thanks
	Andrew