netdev - Re: [PATCH 2/3] sunhme: fix the version number in struct ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yf6mtvA1zO7cdzr7@lunn.ch>
Date:   Sat, 5 Feb 2022 17:32:54 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Rolf Eike Beer <eike-kernel@...tec.de>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] sunhme: fix the version number in struct
 ethtool_drvinfo

> > If it is not used anywhere else, yes, you can remove it.
> 
> Of course it prints the number on module load… but otherwise it does nothing 
> with it.

You could remove that as well.

The basic problem is, the version string does not identify the sources
with enough accuracy. It says nothing about back ported fixes in
stable kernels. It tells you nothing about vendor patches to the
network core, etc.

	Andrew