netdev - Re: [PATCH v7 net-next 06/10] net: dsa: microchip: add support for phylink management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4603640dba2699c97fd966ec7a0dec6db53529ae.camel@microchip.com>
Date:   Mon, 7 Feb 2022 22:28:20 +0530
From:   Prasanna Vengateshan <prasanna.vengateshan@...rochip.com>
To:     "Russell King (Oracle)" <linux@...linux.org.uk>
CC:     <andrew@...n.ch>, <netdev@...r.kernel.org>, <olteanv@...il.com>,
        <robh+dt@...nel.org>, <UNGLinuxDriver@...rochip.com>,
        <Woojung.Huh@...rochip.com>, <hkallweit1@...il.com>,
        <davem@...emloft.net>, <kuba@...nel.org>,
        <linux-kernel@...r.kernel.org>, <vivien.didelot@...il.com>,
        <f.fainelli@...il.com>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH v7 net-next 06/10] net: dsa: microchip: add support for
 phylink management

On Fri, 2022-02-04 at 18:14 +0000, Russell King (Oracle) wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> able to be laid out with the two pause modes first followed by the
> speeds.
> 
> > +                     phy_interface_set_rgmii(config->supported_interfaces);
> > +
> > +                     __set_bit(PHY_INTERFACE_MODE_MII,
> > +                               config->supported_interfaces);
> > +                     __set_bit(PHY_INTERFACE_MODE_RMII,
> > +                               config->supported_interfaces);
> > +             }
> > +     }
> 
> You seem to be a non-legacy driver in this patch (good!) so please also
> add:
> 
>         config->legacy_pre_march2020 = false;
> 
> while DSA is transitioned over. Thanks.

Sure, thanks for the feedback. I will change it in the next revision.

Prasanna
>