netdev - Re: [PATCH v18, 2/2] net: Add dm9051 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Feb 2022 09:43:31 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Joseph CHAMG <josright123@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>, joseph_chang@...icom.com.tw,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, andy.shevchenko@...il.com,
        andrew@...n.ch, leon@...nel.org
Subject: Re: [PATCH v18, 2/2] net: Add dm9051 driver

On Mon,  7 Feb 2022 17:09:06 +0800 Joseph CHAMG wrote:
> Add davicom dm9051 spi ethernet driver, The driver work for the
> device platform which has the spi master
> 
> Signed-off-by: Joseph CHAMG <josright123@...il.com>

In file included from include/linux/etherdevice.h:21,
                 from drivers/net/ethernet/davicom/dm9051.c:7:
drivers/net/ethernet/davicom/dm9051.c: In function ‘dm9051_rxctl_delay’:
drivers/net/ethernet/davicom/dm9051.c:930:42: warning: format ‘%d’ expects argument of type ‘int’, but argument 6 has type ‘long unsigned int’ [-Wformat=]
  930 |                 netif_err(db, drv, ndev, "%s: error %d bulk writing reg %02x, len %d\n",
      |                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  931 |                           __func__, result, DM9051_PAR, sizeof(ndev->dev_addr));
      |                                                         ~~~~~~~~~~~~~~~~~~~~~~
      |                                                         |
      |                                                         long unsigned int
include/linux/netdevice.h:5107:37: note: in definition of macro ‘netif_level’
 5107 |                 netdev_##level(dev, fmt, ##args);               \
      |                                     ^~~
drivers/net/ethernet/davicom/dm9051.c:930:17: note: in expansion of macro ‘netif_err’
  930 |                 netif_err(db, drv, ndev, "%s: error %d bulk writing reg %02x, len %d\n",
      |                 ^~~~~~~~~
drivers/net/ethernet/davicom/dm9051.c:930:84: note: format string is defined here
  930 |                 netif_err(db, drv, ndev, "%s: error %d bulk writing reg %02x, len %d\n",
      |                                                                                   ~^
      |                                                                                    |
      |                                                                                    int
      |                                                                                   %ld