netdev - Re: [v6] dsa: mv88e6xxx: make serdes SGMII/Fiber tx amplitude configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220210151635.4b170f5c@dellmb>
Date:   Thu, 10 Feb 2022 15:16:35 +0100
From:   Marek Behún <kabel@...nel.org>
To:     Holger Brunck <holger.brunck@...achienergy.com>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [v6] dsa: mv88e6xxx: make serdes SGMII/Fiber tx amplitude
 configurable

On Thu, 10 Feb 2022 09:43:22 +0100
Holger Brunck <holger.brunck@...achienergy.com> wrote:

> The mv88e6352, mv88e6240 and mv88e6176  have a serdes interface. This patch
> allows to configure the output swing to a desired value in the
> phy-handle of the port. The value which is peak to peak has to be
> specified in microvolts. As the chips only supports eight dedicated
> values we return EINVAL if the value in the DTS does not match one of
> these values.
> 
> CC: Andrew Lunn <andrew@...n.ch>
> CC: Jakub Kicinski <kuba@...nel.org>
> CC: Marek Behún <kabel@...nel.org>
> Signed-off-by: Holger Brunck <holger.brunck@...achienergy.com>

Reviewed-by: Marek Behún <kabel@...nel.org>

Keep in mind that the tx-p2p-amplitude DT property is not merged in DT
yet. I suggest you resend this patch as a series of 2 patches, the
first being the DT patch:
  https://lore.kernel.org/linux-devicetree/20220119131117.30245-1-kabel@kernel.org/
where you should also add Rob's reviewed-by tag, which he sent in
  https://lore.kernel.org/linux-devicetree/YgGBe0BS%2Fd0lOVtU@robh.at.kernel.org/

Marek