lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 12 Feb 2022 12:03:49 +0100
From: Lorenzo Bianconi <lorenzo@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: bpf@...r.kernel.org, netdev@...r.kernel.org, davem@...emloft.net,
ast@...nel.org, daniel@...earbox.net, brouer@...hat.com,
toke@...hat.com, pabeni@...hat.com, echaudro@...hat.com,
lorenzo.bianconi@...hat.com, toshiaki.makita1@...il.com,
andrii@...nel.org
Subject: Re: [PATCH bpf-next 2/3] veth: rework veth_xdp_rcv_skb in order to
accept non-linear skb
On Feb 11, Jakub Kicinski wrote:
> On Fri, 11 Feb 2022 02:20:31 +0100 Lorenzo Bianconi wrote:
> > + if (skb_shared(skb) || skb_head_is_locked(skb)) {
>
> Is this sufficient to guarantee that the frags can be written?
> skb_cow_data() tells a different story.
Do you mean to consider paged part of the skb always not writable, right?
In other words, we should check something like:
if (skb_shared(skb) || skb_head_is_locked(skb) ||
skb_shinfo(skb)->nr_frags) {
...
}
Regards,
Lorenzo
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists