netdev - Re: [PATCH net-next 1/1] ice: add TTY for GNSS module for E810T device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220215001807.GA16337@hoboy.vegasvil.org>
Date:   Mon, 14 Feb 2022 16:18:07 -0800
From:   Richard Cochran <richardcochran@...il.com>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     davem@...emloft.net, kuba@...nel.org,
        Karol Kolacinski <karol.kolacinski@...el.com>,
        netdev@...r.kernel.org,
        Sudhansu Sekhar Mishra <sudhansu.mishra@...el.com>,
        Sunitha Mekala <sunithax.d.mekala@...el.com>
Subject: Re: [PATCH net-next 1/1] ice: add TTY for GNSS module for E810T
 device

On Mon, Feb 14, 2022 at 03:15:36PM -0800, Tony Nguyen wrote:

> diff --git a/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h b/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h
> index fd8ee5b7f596..a23a9ea10751 100644
> --- a/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h
> +++ b/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h
> @@ -1401,6 +1401,24 @@ struct ice_aqc_get_link_topo {
>  	u8 rsvd[9];
>  };
>  
> +/* Read I2C (direct, 0x06E2) */
> +struct ice_aqc_i2c {
> +	struct ice_aqc_link_topo_addr topo_addr;
> +	__le16 i2c_addr;
> +	u8 i2c_params;
> +#define ICE_AQC_I2C_DATA_SIZE_S		0
> +#define ICE_AQC_I2C_DATA_SIZE_M		(0xF << ICE_AQC_I2C_DATA_SIZE_S)
> +#define ICE_AQC_I2C_USE_REPEATED_START	BIT(7)

Nit:  #define belongs at top of file, or at least outside of structure definition.

> +	u8 rsvd;
> +	__le16 i2c_bus_addr;
> +	u8 rsvd2[4];
> +};

Thanks,
Richard