netdev - Re: [PATCH net-next 1/1] ice: add TTY for GNSS module for E810T device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4242cef091c867f93164b88c6c9613e982711abc.camel@intel.com>
Date:   Tue, 15 Feb 2022 19:18:44 +0000
From:   "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
To:     "richardcochran@...il.com" <richardcochran@...il.com>
CC:     "Mekala, SunithaX D" <sunithax.d.mekala@...el.com>,
        "Mishra, Sudhansu Sekhar" <sudhansu.mishra@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "Kolacinski, Karol" <karol.kolacinski@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/1] ice: add TTY for GNSS module for E810T
 device

Hi Richard,

On Mon, 2022-02-14 at 16:18 -0800, Richard Cochran wrote:
> On Mon, Feb 14, 2022 at 03:15:36PM -0800, Tony Nguyen wrote:
> 
> > diff --git a/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h
> > b/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h
> > index fd8ee5b7f596..a23a9ea10751 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h
> > +++ b/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h
> > @@ -1401,6 +1401,24 @@ struct ice_aqc_get_link_topo {
> >         u8 rsvd[9];
> >  };
> >  
> > +/* Read I2C (direct, 0x06E2) */
> > +struct ice_aqc_i2c {
> > +       struct ice_aqc_link_topo_addr topo_addr;
> > +       __le16 i2c_addr;
> > +       u8 i2c_params;
> > +#define ICE_AQC_I2C_DATA_SIZE_S                0
> > +#define ICE_AQC_I2C_DATA_SIZE_M                (0xF <<
> > ICE_AQC_I2C_DATA_SIZE_S)
> > +#define ICE_AQC_I2C_USE_REPEATED_START BIT(7)
> 
> Nit:  #define belongs at top of file, or at least outside of
> structure definition.

These are the bits that directly relate to the fields for the HW-SW
structures. It's more readable and easier to correlate by keeping these
defines next to the fields they relate to.

Thanks,
Tony
> 

> > +       u8 rsvd;
> > +       __le16 i2c_bus_addr;
> > +       u8 rsvd2[4];
> > +};
> 
> Thanks,
> Richard