netdev - Re: [PATCH net-next 1/2] net: transition netdev reg state earlier in run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJfLfpYWnvUUkda2-zXEdJkCu4ziaDN7wQyeEDA4t-pPg@mail.gmail.com>
Date:   Tue, 15 Feb 2022 15:56:48 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>, Xin Long <lucien.xin@...il.com>
Subject: Re: [PATCH net-next 1/2] net: transition netdev reg state earlier in run_todo

On Tue, Feb 15, 2022 at 2:53 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> In prep for unregistering netdevs out of order move the netdev
> state validation and change outside of the loop.
>
> While at it modernize this code and use WARN() instead of
> pr_err() + dump_stack().
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>