netdev - Re: [PATCH net-next 2/2] net: allow out-of-order netdev unregistration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iL+rTkCH18M+iKryu+7vd4fLDmOgVmnWdbJLbFdu_dxBg@mail.gmail.com>
Date:   Tue, 15 Feb 2022 16:01:56 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>, Xin Long <lucien.xin@...il.com>
Subject: Re: [PATCH net-next 2/2] net: allow out-of-order netdev unregistration

On Tue, Feb 15, 2022 at 2:53 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Sprinkle for each loops to allow netdevices to be unregistered
> out of order, as their refs are released.
>
> This prevents problems caused by dependencies between netdevs
> which want to release references in their ->priv_destructor.
> See commit d6ff94afd90b ("vlan: move dev_put into vlan_dev_uninit")
> for example.
>
> Eric has removed the only known ordering requirement in
> commit c002496babfd ("Merge branch 'ipv6-loopback'")
> so let's try this and see if anything explodes...
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>

SGTM, thanks !

Reviewed-by: Eric Dumazet <edumazet@...gle.com>