netdev - RE: [net] tipc: fix wrong publisher node address in link publications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 15 Feb 2022 08:16:17 +0000
From:   Hoang Huu Le <hoang.h.le@...tech.com.au>
To:     "jmaloy@...hat.com" <jmaloy@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "kuba@...nel.org" <kuba@...nel.org>,
        "tipc-discussion@...ts.sourceforge.net" 
        <tipc-discussion@...ts.sourceforge.net>,
        Tung Quang Nguyen <tung.q.nguyen@...tech.com.au>,
        Tuong Tong Lien <tuong.t.lien@...tech.com.au>,
        "maloy@...jonn.com" <maloy@...jonn.com>,
        "xinl@...hat.com" <xinl@...hat.com>,
        "ying.xue@...driver.com" <ying.xue@...driver.com>,
        "parthasarathy.bhuvaragan@...il.com" 
        <parthasarathy.bhuvaragan@...il.com>
Subject: RE: [net] tipc: fix wrong publisher node address in link publications

Hi Jon,

It seems this fix caused a problem with user type service as its always treated as node scope.
The sending side does not know a service binding on peer node as it looks up on itself node address.

Regards,
Hoang
> -----Original Message-----
> From: jmaloy@...hat.com <jmaloy@...hat.com>
> Sent: Monday, February 14, 2022 8:39 AM
> To: netdev@...r.kernel.org; davem@...emloft.net
> Cc: kuba@...nel.org; tipc-discussion@...ts.sourceforge.net; Tung Quang Nguyen <tung.q.nguyen@...tech.com.au>; Hoang Huu Le
> <hoang.h.le@...tech.com.au>; Tuong Tong Lien <tuong.t.lien@...tech.com.au>; jmaloy@...hat.com; maloy@...jonn.com;
> xinl@...hat.com; ying.xue@...driver.com; parthasarathy.bhuvaragan@...il.com
> Subject: [net] tipc: fix wrong publisher node address in link publications
> 
> From: Jon Maloy <jmaloy@...hat.com>
> 
> When a link comes up we add its presence to the name table to make it
> possible for users to subscribe for link up/down events. However, after
> a previous call signature change the binding is wrongly published with
> the peer node as publishing node, instead of the own node as it should
> be. This has the effect that the command 'tipc name table show' will
> list the link binding (service type 2) with node scope and a peer node
> as originator, something that obviously is impossible.
> 
> We correct this bug here.
> 
> Fixes: 50a3499ab853 ("tipc: simplify signature of tipc_namtbl_publish()")
> 
> Signed-off-by: Jon Maloy <jmaloy@...hat.com>
> ---
>  net/tipc/node.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/tipc/node.c b/net/tipc/node.c
> index 9947b7dfe1d2..fd95df338da7 100644
> --- a/net/tipc/node.c
> +++ b/net/tipc/node.c
> @@ -413,7 +413,7 @@ static void tipc_node_write_unlock(struct tipc_node *n)
>  	tipc_uaddr(&ua, TIPC_SERVICE_RANGE, TIPC_NODE_SCOPE,
>  		   TIPC_LINK_STATE, n->addr, n->addr);
>  	sk.ref = n->link_id;
> -	sk.node = n->addr;
> +	sk.node = tipc_own_addr(net);
>  	bearer_id = n->link_id & 0xffff;
>  	publ_list = &n->publ_list;
> 
> --
> 2.31.1