netdev - Re: [PATCH v3 5/8] ARM: dts: exynos: fix ethernet node name for different odroid boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220215081645.GD672@pengutronix.de>
Date:   Tue, 15 Feb 2022 09:16:45 +0100
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Marc Kleine-Budde <mkl@...gutronix.de>
Cc:     Tony Lindgren <tony@...mide.com>,
        linux-samsung-soc@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Jakub Kicinski <kuba@...nel.org>, devicetree@...r.kernel.org,
        Nicolas Saenz Julienne <nsaenz@...nel.org>,
        Benoît Cousson <bcousson@...libre.com>,
        Ray Jui <rjui@...adcom.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        linux-rpi-kernel@...ts.infradead.org, linux-tegra@...r.kernel.org,
        Florian Fainelli <f.fainelli@...il.com>,
        linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Scott Branden <sbranden@...adcom.com>, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...gutronix.de, Shawn Guo <shawnguo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH v3 5/8] ARM: dts: exynos: fix ethernet node name for
 different odroid boards

On Tue, Feb 15, 2022 at 09:12:40AM +0100, Marc Kleine-Budde wrote:
> On 15.02.2022 09:09:34, Oleksij Rempel wrote:
> > The node name of Ethernet controller should be "ethernet" instead of
> > "usbether"
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> > ---
> >  arch/arm/boot/dts/exynos4412-odroidu3.dts       | 4 ++--
> >  arch/arm/boot/dts/exynos4412-odroidx.dts        | 8 ++++----
> >  arch/arm/boot/dts/exynos5410-odroidxu.dts       | 4 ++--
> >  arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts | 6 +++---
> >  arch/arm/boot/dts/exynos5422-odroidxu3.dts      | 6 +++---
> >  5 files changed, 14 insertions(+), 14 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
> > index efaf7533e84f..36c369c42b77 100644
> > --- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
> > +++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
> > @@ -119,8 +119,8 @@ &ehci {
> >  	phys = <&exynos_usbphy 2>, <&exynos_usbphy 3>;
> >  	phy-names = "hsic0", "hsic1";
> >  
> > -	ethernet: usbether@2 {
> > -		compatible = "usb0424,9730";
> > +	ethernet: ethernet@2 {
> > +		compatible = "usb424,9730";
> 
> The change of the compatible is not mentioned in the patch description.
> Is this intentional?

No, I forgot to mentione it. According to the USB schema 0 should be
removed. So, this compatible was incorrect as well. With leading zero
present yaml schema was not able to detect and validate this node.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |