[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20220215163545.0a421b9a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date: Tue, 15 Feb 2022 16:35:45 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: netdev@...r.kernel.org
Subject: Re: [Bug 215610] New: eth0 not working after upgrade from 5.16.8 to
5.16.9
On Tue, 15 Feb 2022 15:22:33 -0800 Stephen Hemminger wrote:
> Begin forwarded message:
>
> Date: Tue, 15 Feb 2022 16:24:06 +0000
> From: bugzilla-daemon@...nel.org
> To: stephen@...workplumber.org
> Subject: [Bug 215610] New: eth0 not working after upgrade from 5.16.8 to 5.16.9
>
>
> https://bugzilla.kernel.org/show_bug.cgi?id=215610
>
> Bug ID: 215610
> Summary: eth0 not working after upgrade from 5.16.8 to 5.16.9
> Product: Networking
> Version: 2.5
> Kernel Version: 5.16.9
> Hardware: All
> OS: Linux
> Tree: Mainline
> Status: NEW
> Severity: normal
> Priority: P1
> Component: Other
> Assignee: stephen@...workplumber.org
> Reporter: joerg.sigle@...gle.com
> Regression: No
>
> After rebooting with kernel 5.16.9, the eth0 connection did not work any more.
>
> The interface is shown in ifconfig, but ping or other services don't reach any
> machines in the LAN or in the internet.
>
> I've not done much research but went back to 5.16.8 which works well again.
>
> In 5.16.8, lspci shows:
>
> 00:19.0 Ethernet controller: Intel Corporation Ethernet Connection I217-LM (rev
> 04)
> Subsystem: Lenovo Ethernet Connection I217-LM
> Flags: bus master, fast devsel, latency 0, IRQ 33
> Memory at b4a00000 (32-bit, non-prefetchable) [size=128K]
> Memory at b4a3e000 (32-bit, non-prefetchable) [size=4K]
> I/O ports at 5080 [size=32]
> Capabilities: [c8] Power Management version 2
> Capabilities: [d0] MSI: Enable+ Count=1/1 Maskable- 64bit+
> Capabilities: [e0] PCI Advanced Features
> Kernel driver in use: e1000e
There's nothing in there:
$ git log v5.16.8..v5.16.9 -- drivers/net/ethernet/intel/
$ git log v5.16.8..v5.16.9 -- net/
commit 59ff7514f8c56f166aadca49bcecfa028e0ad50f
Author: Jon Maloy <jmaloy@...hat.com>
Date: Sat Feb 5 14:11:18 2022 -0500
tipc: improve size validations for received domain records
commit 9aa422ad326634b76309e8ff342c246800621216 upstream.
The function tipc_mon_rcv() allows a node to receive and process
domain_record structs from peer nodes to track their views of the
network topology.
This patch verifies that the number of members in a received domain
record does not exceed the limit defined by MAX_MON_DOMAIN, something
that may otherwise lead to a stack overflow.
tipc_mon_rcv() is called from the function tipc_link_proto_rcv(), where
we are reading a 32 bit message data length field into a uint16. To
avert any risk of bit overflow, we add an extra sanity check for this in
that function. We cannot see that happen with the current code, but
future designers being unaware of this risk, may introduce it by
allowing delivery of very large (> 64k) sk buffers from the bearer
layer. This potential problem was identified by Eric Dumazet.
This fixes CVE-2022-0435
Reported-by: Samuel Page <samuel.page@...gate.com>
Reported-by: Eric Dumazet <edumazet@...gle.com>
Fixes: 35c55c9877f8 ("tipc: add neighbor monitoring framework")
Signed-off-by: Jon Maloy <jmaloy@...hat.com>
Reviewed-by: Xin Long <lucien.xin@...il.com>
Reviewed-by: Samuel Page <samuel.page@...gate.com>
Reviewed-by: Eric Dumazet <edumazet@...gle.com>
Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Powered by blists - more mailing lists