netdev - Re: [PATCH v3 net-next 02/11] net: bridge: vlan: don't notify to switchdev master VLANs without BRENTRY flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Feb 2022 13:11:39 +0200
From:   Nikolay Aleksandrov <nikolay@...dia.com>
To:     Vladimir Oltean <vladimir.oltean@....com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Roopa Prabhu <roopa@...dia.com>, Jiri Pirko <jiri@...dia.com>,
        Ido Schimmel <idosch@...dia.com>,
        Rafael Richter <rafael.richter@....de>,
        Daniel Klauer <daniel.klauer@....de>,
        Tobias Waldekranz <tobias@...dekranz.com>
Subject: Re: [PATCH v3 net-next 02/11] net: bridge: vlan: don't notify to
 switchdev master VLANs without BRENTRY flag

On 16/02/2022 13:10, Vladimir Oltean wrote:
> On Wed, Feb 16, 2022 at 01:00:27PM +0200, Nikolay Aleksandrov wrote:
>>> +		if (br_vlan_should_use(v)) {
>>> +			err = br_switchdev_port_vlan_add(dev, v->vid, flags,
>>> +							 extack);
>>> +			if (err && err != -EOPNOTSUPP)
>>> +				goto out;
>>> +		}
>>
>> At some point we should just pass the vlan struct to the switchdev handlers
>> and push all the switchdev-specific checks in there. It would require some
>> care w.r.t kconfig options, but it should be cleaner.
>> The patch looks good.
>>
>> Acked-by: Nikolay Aleksandrov <nikolay@...dia.com>
> 
> Here and there we're passing "flags" and not "v->flags", so passing the
> net_bridge_vlan structure to br_switchdev_port_vlan_add() would require
> committing to it the changes we want to do, which is pretty much what
> we've been avoiding since v1.

No, it won't. I didn't say we should stop passing flags.
It will be passed along with the vlan struct where you'd have the old flags
that you pass separately now, so all checks can be done on it.