netdev - Re: [PATCH v3 net-next 03/11] net: bridge: vlan: make __vlan_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2c0d6e7-72d6-ce92-894b-711e67f2f70a@nvidia.com>
Date:   Wed, 16 Feb 2022 13:22:33 +0200
From:   Nikolay Aleksandrov <nikolay@...dia.com>
To:     Vladimir Oltean <vladimir.oltean@....com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Roopa Prabhu <roopa@...dia.com>, Jiri Pirko <jiri@...dia.com>,
        Ido Schimmel <idosch@...dia.com>,
        Rafael Richter <rafael.richter@....de>,
        Daniel Klauer <daniel.klauer@....de>,
        Tobias Waldekranz <tobias@...dekranz.com>
Subject: Re: [PATCH v3 net-next 03/11] net: bridge: vlan: make
 __vlan_add_flags react only to PVID and UNTAGGED

On 16/02/2022 13:08, Vladimir Oltean wrote:
> On Wed, Feb 16, 2022 at 01:03:54PM +0200, Nikolay Aleksandrov wrote:
>> This patch is unnecessary and can be dropped given the next one.
> 
> Not unnecessary, it reduces the complexity of the next change and makes
> for a cleaner transformation of __vlan_add_flags(), one that doesn't
> affect its commit behavior. The behavior change will matter for patch 4.

As I said in the reply of my reply - nevermind my comment. I agree that the
description of the transformation is good to have and to be explicit.