netdev - Re: [PATCH net-next 5/5] bonding: add new option ns_ip6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c13d92e2-3ac5-58cb-2b21-ebe03e640983@gmail.com>
Date:   Wed, 16 Feb 2022 09:38:31 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     Jay Vosburgh <j.vosburgh@...il.com>,
        Veaceslav Falico <vfalico@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Nikolay Aleksandrov <nikolay@...dia.com>,
        Jonathan Toppins <jtoppins@...hat.com>
Subject: Re: [PATCH net-next 5/5] bonding: add new option ns_ip6_target


On 2/16/22 00:08, Hangbin Liu wrote:
> This patch add a new bonding option ns_ip6_target, which correspond
> to the arp_ip_target. With this we set IPv6 targets and send IPv6 NS
> request to determine the health of the link.
>
> For other related options like the validation, we still use
> arp_validate, and will change to ns_validate later.
>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>   Documentation/networking/bonding.rst |  11 +++
>   drivers/net/bonding/bond_netlink.c   |  59 ++++++++++++
>   drivers/net/bonding/bond_options.c   | 138 +++++++++++++++++++++++++++
>   drivers/net/bonding/bond_sysfs.c     |  26 +++++

Thanks for the patches !

Do we really need to add sysfs parts, now rtnetlink is everywhere ?


>   include/net/bond_options.h           |   4 +
>   include/net/bonding.h                |   7 ++
>   include/uapi/linux/if_link.h         |   1 +
>   tools/include/uapi/linux/if_link.h   |   1 +
>   8 files changed, 247 insertions(+)
>
> diff --git a/Documentation/networking/bonding.rst b/Documentation/networking/bonding.rst
> index ab98373535ea..525e6842dd33 100644
> --- a/Documentation/networking/bonding.rst
> +++ b/Documentation/networking/bonding.rst
> @@ -313,6 +313,17 @@ arp_ip_target
>   	maximum number of targets that can be specified is 16.  The
>   	default value is no IP addresses.
>   
> +ns_ip6_target
> +
> +	Specifies the IPv6 addresses to use as IPv6 monitoring peers when
> +	arp_interval is > 0.  These are the targets of the NS request
> +	sent to determine the health of the link to the targets.
> +	Specify these values in ffff:ffff::ffff:ffff format.  Multiple IPv6
> +	addresses must be separated by a comma.  At least one IPv6
> +	address must be given for NS/NA monitoring to function.  The
> +	maximum number of targets that can be specified is 16.  The
> +	default value is no IPv6 addresses.
> +
>   arp_validate
>   
>