netdev - Re: [PATCH net-next 5/5] bonding: add new option ns_ip6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yg2kGkGKRTVXObYh@Laptop-X1>
Date:   Thu, 17 Feb 2022 09:25:46 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     netdev@...r.kernel.org, Jay Vosburgh <j.vosburgh@...il.com>,
        Veaceslav Falico <vfalico@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Nikolay Aleksandrov <nikolay@...dia.com>,
        Jonathan Toppins <jtoppins@...hat.com>
Subject: Re: [PATCH net-next 5/5] bonding: add new option ns_ip6_target

On Wed, Feb 16, 2022 at 09:38:31AM -0800, Eric Dumazet wrote:
> 
> On 2/16/22 00:08, Hangbin Liu wrote:
> > This patch add a new bonding option ns_ip6_target, which correspond
> > to the arp_ip_target. With this we set IPv6 targets and send IPv6 NS
> > request to determine the health of the link.
> > 
> > For other related options like the validation, we still use
> > arp_validate, and will change to ns_validate later.
> > 
> > Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> > ---
> >   Documentation/networking/bonding.rst |  11 +++
> >   drivers/net/bonding/bond_netlink.c   |  59 ++++++++++++
> >   drivers/net/bonding/bond_options.c   | 138 +++++++++++++++++++++++++++
> >   drivers/net/bonding/bond_sysfs.c     |  26 +++++
> 
> Thanks for the patches !
> 
> Do we really need to add sysfs parts, now rtnetlink is everywhere ?

For Bonding I think yes. Bonding has disallowed to config via module_param.
But there are still users using sysfs for bonding configuration.

Jay, Veaceslav, please correct me if you think we can stop using sysfs.

Thanks
Hangbin