netdev - Re: [PATCH bpf-next] bpf: bpf_prog_pack: set proper size before freeing ro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <164513281025.23518.1271858389443633598.git-patchwork-notify@kernel.org>
Date:   Thu, 17 Feb 2022 21:20:10 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Song Liu <song@...nel.org>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org, ast@...nel.org,
        daniel@...earbox.net, andrii@...nel.org, kernel-team@...com,
        syzbot+2f649ec6d2eea1495a8f@...kaller.appspotmail.com,
        syzbot+ecb1e7e51c52f68f7481@...kaller.appspotmail.com,
        syzbot+87f65c75f4a72db05445@...kaller.appspotmail.com
Subject: Re: [PATCH bpf-next] bpf: bpf_prog_pack: set proper size before freeing
 ro_header

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@...nel.org>:

On Thu, 17 Feb 2022 10:30:01 -0800 you wrote:
> bpf_prog_pack_free() uses header->size to decide whether the header
> should be freed with module_memfree() or the bpf_prog_pack logic.
> However, in kvmalloc() failure path of bpf_jit_binary_pack_alloc(),
> header->size is not set yet. As a result, bpf_prog_pack_free() may treat
> a slice of a pack as a standalone kvmalloc'd header and call
> module_memfree() on the whole pack. This in turn causes use-after-free by
> other users of the pack.
> 
> [...]

Here is the summary with links:
  - [bpf-next] bpf: bpf_prog_pack: set proper size before freeing ro_header
    https://git.kernel.org/bpf/bpf-next/c/d24d2a2b0a81

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html