netdev - Re: [PATCH net 1/7] bnxt_en: Fix active FEC reporting to ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220222112320.1a12b91c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 22 Feb 2022 11:23:20 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Michael Chan <michael.chan@...adcom.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, gospo@...adcom.com,
        Somnath Kotur <somnath.kotur@...adcom.com>
Subject: Re: [PATCH net 1/7] bnxt_en: Fix active FEC reporting to ethtool

On Sun, 20 Feb 2022 04:05:47 -0500 Michael Chan wrote:
> From: Somnath Kotur <somnath.kotur@...adcom.com>
> 
> ethtool --show-fec <interface> does not show anything when the Active
> FEC setting in the chip is set to None.  Fix it to properly return
> ETHTOOL_FEC_OFF in that case.

Just to be clear - this means:
 - the chip supports FEC but None is selected? Or
 - the chip does not support FEC?

> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> index 003330e8cd58..e195f4a669d8 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> @@ -1969,6 +1969,9 @@ static int bnxt_get_fecparam(struct net_device *dev,
>  	case PORT_PHY_QCFG_RESP_ACTIVE_FEC_FEC_RS272_IEEE_ACTIVE:
>  		fec->active_fec |= ETHTOOL_FEC_LLRS;
>  		break;
> +	case PORT_PHY_QCFG_RESP_ACTIVE_FEC_FEC_NONE_ACTIVE:
> +		fec->active_fec |= ETHTOOL_FEC_OFF;
> +		break;
>  	}
>  	return 0;
>  }