netdev - Re: [PATCH net 1/7] bnxt_en: Fix active FEC reporting to ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACKFLin9sbgnThjqFpeBZPQmx7WexCujzvoGjuqKYfWkhACycg@mail.gmail.com>
Date:   Tue, 22 Feb 2022 12:06:24 -0800
From:   Michael Chan <michael.chan@...adcom.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        Andrew Gospodarek <gospo@...adcom.com>,
        Somnath Kotur <somnath.kotur@...adcom.com>
Subject: Re: [PATCH net 1/7] bnxt_en: Fix active FEC reporting to ethtool

On Tue, Feb 22, 2022 at 11:23 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Sun, 20 Feb 2022 04:05:47 -0500 Michael Chan wrote:
> > From: Somnath Kotur <somnath.kotur@...adcom.com>
> >
> > ethtool --show-fec <interface> does not show anything when the Active
> > FEC setting in the chip is set to None.  Fix it to properly return
> > ETHTOOL_FEC_OFF in that case.
>
> Just to be clear - this means:
>  - the chip supports FEC but None is selected? Or
>  - the chip does not support FEC?

This patch is only changing the reporting of the active FEC setting to
be ETHTOOL_FEC_OFF if firmware determines the negotiated or actual FEC
setting to be None.  It is not changing the reporting of the chip's
FEC capability or the user's selected FEC setting.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)