netdev - Re: [net 04/19] net/mlx5: DR, Don't allow match on IP w/o matching on full ethertype/ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220223152641.2bd501c5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 23 Feb 2022 15:26:41 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Yevgeny Kliteynik <kliteyn@...dia.com>,
        Alex Vesker <valex@...dia.com>,
        Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [net 04/19] net/mlx5: DR, Don't allow match on IP w/o matching
 on full ethertype/ip_version

On Wed, 23 Feb 2022 09:04:15 -0800 Saeed Mahameed wrote:
> From: Yevgeny Kliteynik <kliteyn@...dia.com>
> 
> Currently SMFS allows adding rule with matching on src/dst IP w/o matching
> on full ethertype or ip_version, which is not supported by HW.
> This patch fixes this issue and adds the check as it is done in DMFS.
> 
> Fixes: 26d688e33f88 ("net/mlx5: DR, Add Steering entry (STE) utilities")
> Signed-off-by: Yevgeny Kliteynik <kliteyn@...dia.com>
> Reviewed-by: Alex Vesker <valex@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>

drivers/net/ethernet/mellanox/mlx5/core/steering/dr_ste.c:605:5: warning: symbol 'mlx5dr_ste_build_pre_check_spec' was not declared. Should it be static?
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_ste.c:605:5: warning: no previous prototype for ‘mlx5dr_ste_build_pre_check_spec’ [-Wmissing-prototypes]
  605 | int mlx5dr_ste_build_pre_check_spec(struct mlx5dr_domain *dmn,
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~