netdev - Re: [net 04/19] net/mlx5: DR, Don't allow match on IP w/o matching on full ethertype/ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5509c8e0-1689-783a-4052-85321fb7997e@nvidia.com>
Date:   Thu, 24 Feb 2022 01:35:26 +0200
From:   Yevgeny Kliteynik <kliteyn@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>, Saeed Mahameed <saeed@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Alex Vesker <valex@...dia.com>,
        Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [net 04/19] net/mlx5: DR, Don't allow match on IP w/o matching on
 full ethertype/ip_version


On 24-Feb-22 01:26, Jakub Kicinski wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Wed, 23 Feb 2022 09:04:15 -0800 Saeed Mahameed wrote:
>> From: Yevgeny Kliteynik <kliteyn@...dia.com>
>>
>> Currently SMFS allows adding rule with matching on src/dst IP w/o matching
>> on full ethertype or ip_version, which is not supported by HW.
>> This patch fixes this issue and adds the check as it is done in DMFS.
>>
>> Fixes: 26d688e33f88 ("net/mlx5: DR, Add Steering entry (STE) utilities")
>> Signed-off-by: Yevgeny Kliteynik <kliteyn@...dia.com>
>> Reviewed-by: Alex Vesker <valex@...dia.com>
>> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> 
> drivers/net/ethernet/mellanox/mlx5/core/steering/dr_ste.c:605:5: warning: symbol 'mlx5dr_ste_build_pre_check_spec' was not declared. Should it be static?
> drivers/net/ethernet/mellanox/mlx5/core/steering/dr_ste.c:605:5: warning: no previous prototype for ‘mlx5dr_ste_build_pre_check_spec’ [-Wmissing-prototypes]
>    605 | int mlx5dr_ste_build_pre_check_spec(struct mlx5dr_domain *dmn,
>        |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Thanks Jakub, will sent v2 shortly.

-- YK