netdev - Re: [PATCH net-next 17/36] can: mcp251xfd: mcp251xfd_chip_sleep(): introduce function to bring chip into sleep mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220224083315.bpyswlmccq7fqprz@pengutronix.de>
Date:   Thu, 24 Feb 2022 09:33:15 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        linux-can@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH net-next 17/36] can: mcp251xfd: mcp251xfd_chip_sleep():
 introduce function to bring chip into sleep mode

On 23.02.2022 20:27:16, Jakub Kicinski wrote:
> On Wed, 23 Feb 2022 23:43:13 +0100 Marc Kleine-Budde wrote:
> > This patch adds a new function to bring the chip into sleep mode, and
> > replaces several occurrences of open coded variants.
> > 
> > Link: https://lore.kernel.org/all/20220207131047.282110-5-mkl@pengutronix.de
> > Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
> 
> Build is broken between patch 17 and patch 18 :(
> 
> drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c: In function ‘mcp251xfd_chip_stop’:
> drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c:644:1: error: no return statement in function returning non-void [-Werror=return-type]
>   644 | }
>       | ^
> 

Doh! Sorry for that, fixed and sent a new pull request:

https://lore.kernel.org/all/20220224082726.3000007-1-mkl@pengutronix.de/

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)