netdev - Re: [PATCH net-next 17/36] can: mcp251xfd: mcp251xfd_chip_sleep(): introduce function to bring chip into sleep mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220223202716.3c198594@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 23 Feb 2022 20:27:16 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Marc Kleine-Budde <mkl@...gutronix.de>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        linux-can@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH net-next 17/36] can: mcp251xfd: mcp251xfd_chip_sleep():
 introduce function to bring chip into sleep mode

On Wed, 23 Feb 2022 23:43:13 +0100 Marc Kleine-Budde wrote:
> This patch adds a new function to bring the chip into sleep mode, and
> replaces several occurrences of open coded variants.
> 
> Link: https://lore.kernel.org/all/20220207131047.282110-5-mkl@pengutronix.de
> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>

Build is broken between patch 17 and patch 18 :(

drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c: In function ‘mcp251xfd_chip_stop’:
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c:644:1: error: no return statement in function returning non-void [-Werror=return-type]
  644 | }
      | ^