netdev - Re: [PATCH net-next 1/1] ice: add TTY for GNSS module for E810T device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Feb 2022 17:54:26 +0000
From:   "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
To:     "kuba@...nel.org" <kuba@...nel.org>
CC:     "richardcochran@...il.com" <richardcochran@...il.com>,
        "Mekala, SunithaX D" <sunithax.d.mekala@...el.com>,
        "Mishra, Sudhansu Sekhar" <sudhansu.mishra@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "Kolacinski, Karol" <karol.kolacinski@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/1] ice: add TTY for GNSS module for E810T
 device

On Thu, 2022-02-24 at 10:15 -0800, Jakub Kicinski wrote:
> On Thu, 24 Feb 2022 17:26:15 +0000 Nguyen, Anthony L wrote:
> > If you're okay with this, it looks like this patch still applies
> > cleanly. Would you like me to resend it or did you want to use this
> > one?
> 
> Are we talking about this?
> 
> +struct ice_aqc_i2c {
> +       struct ice_aqc_link_topo_addr topo_addr;
> +       __le16 i2c_addr;
> +       u8 i2c_params;
> +#define ICE_AQC_I2C_DATA_SIZE_S                0
> +#define ICE_AQC_I2C_DATA_SIZE_M                (0xF <<
> ICE_AQC_I2C_DATA_SIZE_S)
> +#define ICE_AQC_I2C_USE_REPEATED_START BIT(7)
> +       u8 rsvd;
> +       __le16 i2c_bus_addr;
> +       u8 rsvd2[4];
> +};
> 
> You can definitely improve it, even with the defines "inline" I'm 
> not sure looking at this code which field those defines pertain to.

I'll add a newline before the rsvd to make the seperation clearer.

> I'm guessing it's i2c_params because the next one is rsvd. Plus you 
> should use kernel FIELD_* or filed_* accessors instead of defining
> masks and shifts separately. I think I'm with Richard.

Will make the FIELD_* changes in the next version.

Thanks,
Tony