netdev - Re: [PATCH net-next 06/14] net: dev: Add hardware stats support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wnhid7l8.fsf@nvidia.com>
Date:   Fri, 25 Feb 2022 21:01:53 +0100
From:   Petr Machata <petrm@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     Petr Machata <petrm@...dia.com>, Ido Schimmel <idosch@...dia.com>,
        <netdev@...r.kernel.org>, <davem@...emloft.net>, <jiri@...dia.com>,
        <razor@...ckwall.org>, <roopa@...dia.com>, <dsahern@...il.com>,
        <andrew@...n.ch>, <mlxsw@...dia.com>
Subject: Re: [PATCH net-next 06/14] net: dev: Add hardware stats support


Jakub Kicinski <kuba@...nel.org> writes:

> On Fri, 25 Feb 2022 18:00:11 +0100 Petr Machata wrote:
>> > What I meant is take out all the link-level / PHY stuff, I don't think
>> > any HW would be reporting these above the physical port. Basically when
>> > you look at struct rtnl_link_stats64 we can remove everything starting
>> > from and including collisions, right?  
>> 
>> My thinking is that stats64 is understood, e.g. formatting this in the
>> iproute2 suite is just a function call away. I imagine this is similar
>> in other userspace tools as well. There are benefits to just reusing
>> what exists, despite not being optimal.
>> 
>> But yeah, those 120 trail bytes are very likely going to be zero.
>> I can shave them if you feel strongly about it.
>
> Yeah, if I'm counting right we're reusing like 38% of the fields, only.
> We're better off with a new structure.

OK.