netdev - Re: [PATCH net-next 06/14] net: dev: Add hardware stats support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220225143728.0e90e482@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Fri, 25 Feb 2022 14:37:28 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Petr Machata <petrm@...dia.com>, <roopa@...dia.com>
Cc:     Ido Schimmel <idosch@...dia.com>, <netdev@...r.kernel.org>,
        <davem@...emloft.net>, <jiri@...dia.com>, <razor@...ckwall.org>,
        <dsahern@...il.com>, <andrew@...n.ch>, <mlxsw@...dia.com>
Subject: Re: [PATCH net-next 06/14] net: dev: Add hardware stats support

On Fri, 25 Feb 2022 21:01:53 +0100 Petr Machata wrote:
> Jakub Kicinski <kuba@...nel.org> writes:
> > Yeah, if I'm counting right we're reusing like 38% of the fields, only.
> > We're better off with a new structure.  
> 
> OK.

Thanks, BTW I noticed that what Roopa has is very close (just missing
multicast):

https://lore.kernel.org/all/20220222025230.2119189-12-roopa@nvidia.com/

There are other structures (grep include/ for rx_bytes) already in tree
but none as close.

That's if you wanted to push for reuse (I presume you may prefer not
to), just an FYI..