netdev - Re: [PATCH bpf-next v4 0/2] bpf, arm64: fix bpf line info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <41819a56-4da8-cc49-c42c-700d599c7af3@iogearbox.net>
Date:   Mon, 28 Feb 2022 13:59:39 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Hou Tao <houtao1@...wei.com>, Alexei Starovoitov <ast@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Will Deacon <will@...nel.org>
Cc:     Song Liu <songliubraving@...com>,
        John Fastabend <john.fastabend@...il.com>,
        Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andrii@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        bpf@...r.kernel.org, Zi Shen Lim <zlim.lnx@...il.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Ard Biesheuvel <ard.biesheuvel@....com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH bpf-next v4 0/2] bpf, arm64: fix bpf line info

On 2/26/22 1:19 PM, Hou Tao wrote:
> Hi,
> 
> The patchset addresses two issues in bpf line info for arm64:
> 
> (1) insn_to_jit_off only considers the body itself and ignores
>      prologue before the body. Fixed in patch #1.
> 
> (2) insn_to_jit_off passed to bpf_prog_fill_jited_linfo() is
>      calculated in instruction granularity instead of bytes
>      granularity. Fixed in patch #2.
> 
> Comments are always welcome.
> 
> Regards,
> Tao

LGTM, applied, thanks Hou!