netdev - Re: [PATCH bpf-next v4 0/2] bpf, arm64: fix bpf line info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Feb 2022 09:15:05 +0800
From:   Hou Tao <houtao1@...wei.com>
To:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin KaFai Lau <kafai@...com>,
        Will Deacon <will@...nel.org>
CC:     Song Liu <songliubraving@...com>,
        John Fastabend <john.fastabend@...il.com>,
        Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andrii@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, <netdev@...r.kernel.org>,
        <bpf@...r.kernel.org>, Zi Shen Lim <zlim.lnx@...il.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Ard Biesheuvel <ard.biesheuvel@....com>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH bpf-next v4 0/2] bpf, arm64: fix bpf line info

Hi,

On 2/26/2022 8:19 PM, Hou Tao wrote:
> Hi,
>
> The patchset addresses two issues in bpf line info for arm64:
>
> (1) insn_to_jit_off only considers the body itself and ignores
>     prologue before the body. Fixed in patch #1.
>
> (2) insn_to_jit_off passed to bpf_prog_fill_jited_linfo() is
>     calculated in instruction granularity instead of bytes
>     granularity. Fixed in patch #2.
>
> Comments are always welcome.
>
> Regards,
> Tao
>
> Change Log:
> v4:
>  * patch #2: convert ctx.offset into byte offset before call
>    bpf_prog_fill_jited_linfo() instead of converting it back and forth.
Oops, forget to add Acked-by tag from Martin
>
> v3: https://lore.kernel.org/bpf/20220208012539.491753-1-houtao1@huawei.com
>  * patch #2: explain why bpf2a64_offset() needs update
>  * add Fixes tags in both patches
>
> v2: https://lore.kernel.org/bpf/20220125105707.292449-1-houtao1@huawei.com
>  * split into two independent patches (from Daniel)
>  * use AARCH64_INSN_SIZE instead of defining INSN_SIZE
>
> v1: https://lore.kernel.org/bpf/20220104014236.1512639-1-houtao1@huawei.com
>
> Hou Tao (2):
>   bpf, arm64: call build_prologue() first in first JIT pass
>   bpf, arm64: feed byte-offset into bpf line info
>
>  arch/arm64/net/bpf_jit_comp.c | 18 +++++++++++++-----
>  1 file changed, 13 insertions(+), 5 deletions(-)
>