netdev - Re: [PATCH net-next] net/smc: fix compile warning for smc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Mar 2022 23:02:23 +0800
From:   kernel test robot <lkp@...el.com>
To:     Dust Li <dust.li@...ux.alibaba.com>,
        Karsten Graul <kgraul@...ux.ibm.com>,
        Tony Lu <tonylu@...ux.alibaba.com>, davem@...emloft.net,
        kuba@...nel.org
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next] net/smc: fix compile warning for smc_sysctl

Hi Dust,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Dust-Li/net-smc-fix-compile-warning-for-smc_sysctl/20220302-114411
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 7282c126f7688f697d33f3b965c29bba67fb4eba
config: sparc-buildonly-randconfig-r005-20220302 (https://download.01.org/0day-ci/archive/20220302/202203022234.AMB3WcyJ-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/4b16b08f4709ad49412ee1df69b6922a370dad46
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Dust-Li/net-smc-fix-compile-warning-for-smc_sysctl/20220302-114411
        git checkout 4b16b08f4709ad49412ee1df69b6922a370dad46
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sparc SHELL=/bin/bash net/smc/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   net/smc/smc_sysctl.c: In function 'smc_sysctl_init_net':
   net/smc/smc_sysctl.c:47:17: error: 'struct netns_smc' has no member named 'smc_hdr'
      47 |         net->smc.smc_hdr = register_net_sysctl(net, "net/smc", table);
         |                 ^
   net/smc/smc_sysctl.c:48:22: error: 'struct netns_smc' has no member named 'smc_hdr'
      48 |         if (!net->smc.smc_hdr)
         |                      ^
   net/smc/smc_sysctl.c: In function 'smc_sysctl_exit_net':
   net/smc/smc_sysctl.c:64:45: error: 'struct netns_smc' has no member named 'smc_hdr'
      64 |         unregister_net_sysctl_table(net->smc.smc_hdr);
         |                                             ^
   net/smc/smc_sysctl.c: At top level:
   net/smc/smc_sysctl.c:72:16: error: redefinition of 'smc_sysctl_init'
      72 | int __net_init smc_sysctl_init(void)
         |                ^~~~~~~~~~~~~~~
   In file included from net/smc/smc_sysctl.c:18:
   net/smc/smc_sysctl.h:23:19: note: previous definition of 'smc_sysctl_init' with type 'int(void)'
      23 | static inline int smc_sysctl_init(void)
         |                   ^~~~~~~~~~~~~~~
>> net/smc/smc_sysctl.c:78:1: warning: ignoring attribute 'noinline' because it conflicts with attribute 'gnu_inline' [-Wattributes]
      78 | {
         | ^
   In file included from net/smc/smc_sysctl.c:18:
   net/smc/smc_sysctl.h:28:20: note: previous declaration here
      28 | static inline void smc_sysctl_exit(void) { }
         |                    ^~~~~~~~~~~~~~~
   net/smc/smc_sysctl.c:77:17: error: redefinition of 'smc_sysctl_exit'
      77 | void __net_exit smc_sysctl_exit(void)
         |                 ^~~~~~~~~~~~~~~
   In file included from net/smc/smc_sysctl.c:18:
   net/smc/smc_sysctl.h:28:20: note: previous definition of 'smc_sysctl_exit' with type 'void(void)'
      28 | static inline void smc_sysctl_exit(void) { }
         |                    ^~~~~~~~~~~~~~~


vim +78 net/smc/smc_sysctl.c

462791bbfa35018 Dust Li 2022-03-01  76  
4b16b08f4709ad4 Dust Li 2022-03-02  77  void __net_exit smc_sysctl_exit(void)
462791bbfa35018 Dust Li 2022-03-01 @78  {

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org