netdev - Re: [PATCH net-next] net/smc: fix compile warning for smc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220302114503.47d64a55@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Wed, 2 Mar 2022 11:45:03 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     kernel test robot <lkp@...el.com>
Cc:     Dust Li <dust.li@...ux.alibaba.com>,
        Karsten Graul <kgraul@...ux.ibm.com>,
        Tony Lu <tonylu@...ux.alibaba.com>, davem@...emloft.net,
        kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next] net/smc: fix compile warning for smc_sysctl

On Wed, 2 Mar 2022 23:02:23 +0800 kernel test robot wrote:
>    In file included from net/smc/smc_sysctl.c:18:
>    net/smc/smc_sysctl.h:23:19: note: previous definition of 'smc_sysctl_init' with type 'int(void)'
>       23 | static inline int smc_sysctl_init(void)
>          |                   ^~~~~~~~~~~~~~~
> >> net/smc/smc_sysctl.c:78:1: warning: ignoring attribute 'noinline' because it conflicts with attribute 'gnu_inline' [-Wattributes]  
>       78 | {
>          | ^

The __net_init / __net_exit attr has to go on the prototype as well.

This doesn't look right, tho, why __net_* attrs?  You call those
functions from the module init/exit. __net_ is for namespace code.