netdev - Re: [PATCH net] net: dsa: restore error path of dsa_tree_change_tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 02 Mar 2022 02:40:10 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev@...r.kernel.org, kuba@...nel.org, davem@...emloft.net,
        f.fainelli@...il.com, andrew@...n.ch, vivien.didelot@...il.com,
        olteanv@...il.com, ansuelsmth@...il.com
Subject: Re: [PATCH net] net: dsa: restore error path of dsa_tree_change_tag_proto

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Mon, 28 Feb 2022 16:17:15 +0200 you wrote:
> When the DSA_NOTIFIER_TAG_PROTO returns an error, the user space process
> which initiated the protocol change exits the kernel processing while
> still holding the rtnl_mutex. So any other process attempting to lock
> the rtnl_mutex would deadlock after such event.
> 
> The error handling of DSA_NOTIFIER_TAG_PROTO was inadvertently changed
> by the blamed commit, introducing this regression. We must still call
> rtnl_unlock(), and we must still call DSA_NOTIFIER_TAG_PROTO for the old
> protocol. The latter is due to the limiting design of notifier chains
> for cross-chip operations, which don't have a built-in error recovery
> mechanism - we should look into using notifier_call_chain_robust for that.
> 
> [...]

Here is the summary with links:
  - [net] net: dsa: restore error path of dsa_tree_change_tag_proto
    https://git.kernel.org/netdev/net/c/0b0e2ff10356

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html