lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Mar 2022 18:42:09 -0800 From: Jakub Kicinski <kuba@...nel.org> To: Dongli Zhang <dongli.zhang@...cle.com> Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, linux-kernel@...r.kernel.org, davem@...emloft.net, rostedt@...dmis.org, mingo@...hat.com, ast@...nel.org, daniel@...earbox.net, andrii@...nel.org, imagedong@...cent.com, joao.m.martins@...cle.com, joe.jin@...cle.com, dsahern@...il.com, edumazet@...gle.com Subject: Re: [PATCH net-next v4 2/4] net: tap: track dropped skb via kfree_skb_reason() On Sat, 26 Feb 2022 00:49:27 -0800 Dongli Zhang wrote: > + SKB_DROP_REASON_SKB_CSUM, /* sk_buff checksum error */ Can we spell it out a little more? It sounds like the checksum was incorrect. Will it be clear that computing the checksum failed, rather than checksum validation failed? > + SKB_DROP_REASON_SKB_COPY_DATA, /* failed to copy data from or to > + * sk_buff > + */ Here should we specify that it's copying from user space? > + SKB_DROP_REASON_SKB_GSO_SEG, /* gso segmentation error */ > + SKB_DROP_REASON_DEV_HDR, /* there is something wrong with > + * device driver specific header > + */ How about: device driver specific header / metadata was invalid to broaden the scope also to devices which don't transfer the metadata in form of a header? > + SKB_DROP_REASON_FULL_RING, /* ring buffer is full */
Powered by blists - more mailing lists