netdev - Re: [PATCH iproute2-next] ss: display advertised TCP receive window and out-of-order counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Mar 2022 08:51:00 -0500
From:   Neal Cardwell <ncardwell@...gle.com>
To:     Davide Caratti <dcaratti@...hat.com>
Cc:     Thomas Higdon <tph@...com>, netdev@...r.kernel.org,
        David Ahern <dsahern@...nel.org>,
        Stefano Brivio <sbrivio@...hat.com>
Subject: Re: [PATCH iproute2-next] ss: display advertised TCP receive window
 and out-of-order counter

On Thu, Mar 3, 2022 at 6:58 AM Davide Caratti <dcaratti@...hat.com> wrote:
>
> these members of TCP_INFO have been included in v5.4.
>
> tested with:
>  # ss -nti
>
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>
> ---
>  misc/ss.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/misc/ss.c b/misc/ss.c
> index f7d369142d93..d77b7f10dc43 100644
> --- a/misc/ss.c
> +++ b/misc/ss.c
> @@ -854,6 +854,8 @@ struct tcpstat {
>         unsigned int        reord_seen;
>         double              rcv_rtt;
>         double              min_rtt;
> +       unsigned int        rcv_ooopack;
> +       unsigned int        snd_wnd;
>         int                 rcv_space;
>         unsigned int        rcv_ssthresh;
>         unsigned long long  busy_time;
> @@ -2654,6 +2656,10 @@ static void tcp_stats_print(struct tcpstat *s)
>                 out(" notsent:%u", s->not_sent);
>         if (s->min_rtt)
>                 out(" minrtt:%g", s->min_rtt);
> +       if (s->rcv_ooopack)
> +               out(" rcv_oopack:%u", s->rcv_ooopack);

It seems there may be a typo where there is a missing 'o' in the
'rcv_oopack' field name that is printed?; probably this should be:

 +               out(" rcv_ooopack:%u", s->rcv_ooopack);

best,
neal