lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 03 Mar 2022 14:59:47 +0100
From:   Toke Høiland-Jørgensen <>
To:     Sebastian Andrzej Siewior <>,,
Cc:     Alexei Starovoitov <>,
        Andrii Nakryiko <>,
        Daniel Borkmann <>,
        "David S. Miller" <>,
        Ingo Molnar <>,
        Jakub Kicinski <>,
        Jesper Dangaard Brouer <>,
        John Fastabend <>,
        KP Singh <>, Martin KaFai Lau <>,
        Song Liu <>,
        Steven Rostedt <>,
        Thomas Gleixner <>,
        Yonghong Song <>
Subject: Re: [PATCH net] xdp: xdp_mem_allocator can be NULL in

Sebastian Andrzej Siewior <> writes:

> Since the commit mentioned below __xdp_reg_mem_model() can return a NULL
> pointer. This pointer is dereferenced in trace_mem_connect() which leads
> to segfault. It can be reproduced with enabled trace events during ifup.
> Only assign the arguments in the trace-event macro if `xa' is set.
> Otherwise set the parameters to 0.
> Fixes: 4a48ef70b93b8 ("xdp: Allow registering memory model without rxq reference")
> Signed-off-by: Sebastian Andrzej Siewior <>

Hmm, so before the commit you mention, the tracepoint wasn't triggered
at all in the code path that now sets xdp_alloc is NULL. So I'm
wondering if we should just do the same here? Is the trace event useful
in all cases?

Alternatively, if we keep it, I think the and mem.type should be
available from rxq->mem, right?


Powered by blists - more mailing lists